Advertisement
  1. This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn More.

[REMOVED] Whois

Comments in 'Plugin Releases' started by hoyinm14mc, Jan 8, 2015.

Thread Status:
Not open for further replies.
  1. Gamecrafter
    Offline

    Gamecrafter

    Joined:
    Nov 20, 2014
    Posts:
    978
    Plugins:
    9
    Wait, I added the online detection code on GitHub. You should check it out before you submit it.
  2. hoyinm14mc
    Offline

    hoyinm14mc Notable Member Plugin Developer

    Joined:
    Jun 4, 2014
    Posts:
    501
    Plugins:
    9
    Minecraft User:
    hoyinm14mc
    no no..
    Not all the code are posted to github
  3. Gamecrafter
    Offline

    Gamecrafter

    Joined:
    Nov 20, 2014
    Posts:
    978
    Plugins:
    9
    Then what's the point of making a repository on GitHub if you're not going to post it? Can you post it? I want to see what you added.
  4. hoyinm14mc
    Offline

    hoyinm14mc Notable Member Plugin Developer

    Joined:
    Jun 4, 2014
    Posts:
    501
    Plugins:
    9
    Minecraft User:
    hoyinm14mc
    After I edit it, I will post to github.
    By the way, did you learn PHP? In line 77-81, it will return true after else because you put '!' before $target->isOnline(). So, it should be this:
    PHP:
    if($target->isOnline()){
      
    $issuer->sendMessage(ChatColor::GREEN."Online: ".ChatColor::WHITE."YES");
    }else{
      
    $issuer->sendMessage(ChatColor::GREEN."Online: ".ChatColor::WHITE."NO");
    }
    Delete '!'
  5. Gamecrafter
    Offline

    Gamecrafter

    Joined:
    Nov 20, 2014
    Posts:
    978
    Plugins:
    9
    I edit the code so that it would look like the format you did it in. You put `!` for everything before it. And I'll add `return true;`.
    hoyinm14mc likes this.
  6. Gamecrafter
    Offline

    Gamecrafter

    Joined:
    Nov 20, 2014
    Posts:
    978
    Plugins:
    9
    Oh yeah, fixed it. I wasn't paying attention to what I was doing earlier.
    hoyinm14mc likes this.
  7. Gamecrafter
    Offline

    Gamecrafter

    Joined:
    Nov 20, 2014
    Posts:
    978
    Plugins:
    9
    Now is it ready to be released/updated?
  8. hoyinm14mc
    Offline

    hoyinm14mc Notable Member Plugin Developer

    Joined:
    Jun 4, 2014
    Posts:
    501
    Plugins:
    9
    Minecraft User:
    hoyinm14mc
    Did you tested in-game?
  9. xiaoq
    Offline

    xiaoq Active Member

    Joined:
    Dec 23, 2014
    Posts:
    232
    Minecraft User:
    xiaoq
    wow,刚才我才汉化了插件...
    hoyinm14mc likes this.
  10. hoyinm14mc
    Offline

    hoyinm14mc Notable Member Plugin Developer

    Joined:
    Jun 4, 2014
    Posts:
    501
    Plugins:
    9
    Minecraft User:
    hoyinm14mc
    iJoshuaHD likes this.
  11. hoyinm14mc
    Offline

    hoyinm14mc Notable Member Plugin Developer

    Joined:
    Jun 4, 2014
    Posts:
    501
    Plugins:
    9
    Minecraft User:
    hoyinm14mc
    I could make a language.yml file xD
  12. Gamecrafter
    Offline

    Gamecrafter

    Joined:
    Nov 20, 2014
    Posts:
    978
    Plugins:
    9
    No, but it should work. There weren't any errors after I corrected everything. Why'd you deleted online status?
  13. xiaoq
    Offline

    xiaoq Active Member

    Joined:
    Dec 23, 2014
    Posts:
    232
    Minecraft User:
    xiaoq
    I can help you translate some word...if you trust my english level
  14. hoyinm14mc
    Offline

    hoyinm14mc Notable Member Plugin Developer

    Joined:
    Jun 4, 2014
    Posts:
    501
    Plugins:
    9
    Minecraft User:
    hoyinm14mc
    ...
    MUST no gramma or speeling mistakes
  15. hoyinm14mc
    Offline

    hoyinm14mc Notable Member Plugin Developer

    Joined:
    Jun 4, 2014
    Posts:
    501
    Plugins:
    9
    Minecraft User:
    hoyinm14mc
    It's because it is useless. I put
    PHP:
    $target $this->getServer()->getPlayer($args[0]);
    Then if you whois a player, he must be online.
  16. xiaoq
    Offline

    xiaoq Active Member

    Joined:
    Dec 23, 2014
    Posts:
    232
    Minecraft User:
    xiaoq
    翻译成中文你觉得我会有 gramma or spelling mistakes吗....话说你spelling拼错了:D
    hoyinm14mc likes this.
  17. hoyinm14mc
    Offline

    hoyinm14mc Notable Member Plugin Developer

    Joined:
    Jun 4, 2014
    Posts:
    501
    Plugins:
    9
    Minecraft User:
    hoyinm14mc
    不要太執著吧...
    xiaoq likes this.
  18. Asparanc
    Offline

    Asparanc Active Member

    Joined:
    Feb 20, 2015
    Posts:
    210
    Minecraft User:
    Asparanc
    Another useful plugin from hoyinm :)
    hoyinm14mc likes this.
  19. iksaku
    Offline

    iksaku Notable Member Plugin Developer

    Joined:
    Sep 2, 2013
    Posts:
    1,130
    Plugins:
    4
    Minecraft User:
    iksaku
    I'm very impressed of your work for implementing EssentialsPE! Just one suggestion: Remove the "player balance" part taken from EssentialsPE, Economy is being implemented but not ready for use, it's pretty stable, but I will not release it by version 1.1.0, so please wait until I officially release it to include the Economy API :3

    And again... Awesome work! I may later suggest you some changes so you can optimize the code :3
    hoyinm14mc likes this.
  20. TrueBaccaAli
    Offline

    TrueBaccaAli Active Member

    Joined:
    Apr 6, 2015
    Posts:
    71
    What are the permission nodes for this plugin?
Thread Status:
Not open for further replies.

Share This Page

Advertisement