Advertisement
  1. This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn More.

Is it ok to modify & add php files on pocketmine

Comments in 'General Discussion' started by UnlimitedCraft, Aug 8, 2015.

  1. UnlimitedCraft
    Offline

    UnlimitedCraft New Member

    Joined:
    Aug 8, 2015
    Posts:
    15
    Minecraft User:
    Erickson123
    Hello guys,

    I tried to modify some pocketmine php so i can add blocks and try to add a mobs and make it work do you think is it legal to do it?

    Yayaya i sucessfully implemented all blocks on my server except working mobs!

    Im a programmer so i can do it by myself only but it will take time because working mobs is i little bit harder

    you can join to my server later when its done.

    Guys if you want this unofficial update for pocketmine just contact me.
  2. JohnMcossley
    Offline

    JohnMcossley New Member

    Joined:
    May 18, 2015
    Posts:
    11
    Minecraft User:
    JohnMcossley
  3. hoyinm14mc
    Offline

    hoyinm14mc Notable Member Plugin Developer

    Joined:
    Jun 4, 2014
    Posts:
    502
    Plugins:
    9
    Minecraft User:
    hoyinm14mc
    Create pull requests http://www.github.com/pocketmine/pocketmine-mp
  4. Gamecrafter
    Offline

    Gamecrafter Notable Member Plugin Developer

    Joined:
    Nov 20, 2014
    Posts:
    981
    Plugins:
    9
    It's okay to modify the PHP files in the source, if you know what you're doing. ;)
    DunxandMinecraft likes this.
  5. Primus
    Offline

    Primus Notable Member

    Joined:
    Apr 7, 2015
    Posts:
    1,472
    Minecraft User:
    PrimusLV
    • Modification of PocketMine-MP source code is not allowed.
    You can edit source code unless you publish it as plugin
  6. Gamecrafter
    Offline

    Gamecrafter Notable Member Plugin Developer

    Joined:
    Nov 20, 2014
    Posts:
    981
    Plugins:
    9
    Misleading. Modification is allowed. If it wasn't, would there be a SteadFast? It is allowed, it's open-sourced.
  7. Primus
    Offline

    Primus Notable Member

    Joined:
    Apr 7, 2015
    Posts:
    1,472
    Minecraft User:
    PrimusLV
    But you cant publish in Plugin Repisotory. Read rules
  8. Gamecrafter
    Offline

    Gamecrafter Notable Member Plugin Developer

    Joined:
    Nov 20, 2014
    Posts:
    981
    Plugins:
    9
    Did he say anything about publishing it here? o_O
    PEMapModder likes this.
  9. Primus
    Offline

    Primus Notable Member

    Joined:
    Apr 7, 2015
    Posts:
    1,472
    Minecraft User:
    PrimusLV
    I did'nt say it's not !
  10. Samueljh1H8sLag
    Offline

    Samueljh1H8sLag Active Member

    Joined:
    Jun 20, 2015
    Posts:
    168
    Minecraft User:
    Samueljh1_
    just make a pull request then the code will be kept throughout all new versions of pocketmine
    hoyinm14mc likes this.
  11. PEMapModder
    Offline

    PEMapModder Notable Member Plugin Developer

    Joined:
    Oct 9, 2013
    Posts:
    7,325
    Plugins:
    11
    Minecraft User:
    PEMapModder
    If modification of PocketMine source code is not allowed, how come I become the third biggest contributor to PocketMine code?
    Modification of PocketMine source in plugins is backwards incompatible. If you want to improve PocketMine, make a pull request like me.

    BTW, they are actually already implemented into the new-blocks branch.
  12. PEMapModder
    Offline

    PEMapModder Notable Member Plugin Developer

    Joined:
    Oct 9, 2013
    Posts:
    7,325
    Plugins:
    11
    Minecraft User:
    PEMapModder
    If you want to add something new to PocketMine, I strongly recommend you to fork PocketMine and create a pull request with your changes.
  13. da123rrell
    Offline

    da123rrell Active Member

    Joined:
    Feb 11, 2015
    Posts:
    136
    Minecraft User:
    da123rrell
    Off topic : did u manage to add rails boats and minecarts?
  14. da123rrell
    Offline

    da123rrell Active Member

    Joined:
    Feb 11, 2015
    Posts:
    136
    Minecraft User:
    da123rrell
    What are implemented?
    UnlimitedCraft likes this.
  15. Thunder33345
    Offline

    Thunder33345 Notable Member

    Joined:
    Apr 3, 2014
    Posts:
    768
    Minecraft User:
    Thunder33345
    yes it is legal to do so
    if you really did please send a pull request to make it official
  16. Artide
    Offline

    Artide Active Member

    Joined:
    Apr 20, 2015
    Posts:
    214
    Minecraft User:
    Artide5
    Don't send it to other people yet, just make a pull request for pocketmine. I think its optimized before released.
  17. UnlimitedCraft
    Offline

    UnlimitedCraft New Member

    Joined:
    Aug 8, 2015
    Posts:
    15
    Minecraft User:
    Erickson123
    yes i do managed!
  18. Thunder33345
    Offline

    Thunder33345 Notable Member

    Joined:
    Apr 3, 2014
    Posts:
    768
    Minecraft User:
    Thunder33345
    SEND IT TO ME PLS I FAN I FAN I FAN
  19. MikkiMCPE
    Offline

    MikkiMCPE Active Member

    Joined:
    May 16, 2015
    Posts:
    128
    Minecraft User:
    MikkiMC
    lol child
  20. da123rrell
    Offline

    da123rrell Active Member

    Joined:
    Feb 11, 2015
    Posts:
    136
    Minecraft User:
    da123rrell
    lol
    wow seriously!!!

Share This Page

Advertisement