Advertisement
  1. This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn More.

Do you want Shoghi to allow VoteReward?

Comments in 'Plugin Development' started by LDX, Jun 7, 2014.

?

Do you want VoteReward to be available on the plugin repository?

  1. Yes

    8 vote(s)
    61.5%
  2. No

    5 vote(s)
    38.5%
Thread Status:
Not open for further replies.
  1. LDX
    Offline

    LDX Notable Member Plugin Developer

    Joined:
    Oct 2, 2013
    Posts:
    1,434
    Plugins:
    14
    So here's what's going on. I developed a plugin that allows players to get a reward when they vote for your server on MinecraftPocket-Servers.com. (Requested by the site's owner, @Endimmion) Shoghi will not allow it on the repository, because every time a player tries to receive their reward, it makes a request to the website, which makes the server lag for 1/100000000000th of a second. This is called blocking the main thread. However, there are multiple plugins by @Falk on the repository right now that use the same method I am using. People are going to get the plugin, anyway, as my inbox is constantly spammed with people saying "Hey can i hav an copy of th reward votes plugn" and things like that. Not to mention, the plugin requests forum is being spammed with threads asking for it, too. If it will get VoteReward approved, I can put a warning at the top of the plugin description that tells them about it's thread blocking thing.

    Please listen to the community, @shoghicp. ;)
    FunneyShip and Lambo like this.
  2. iamadpond
    Offline

    iamadpond Banned

    Joined:
    Aug 24, 2013
    Posts:
    191
    Minecraft User:
    iamadpond
    "If he's using then why can't I?" Those odds stack up as plugins become available. If he let's you, then everyone will complain to get access to the website querying service. And if its a large website it will lag the server, Remember this is being ran on a $10 VPS, not a dedicated server.
    Lambo likes this.
  3. LDX
    Offline

    LDX Notable Member Plugin Developer

    Joined:
    Oct 2, 2013
    Posts:
    1,434
    Plugins:
    14
    Well why does Falk get to do it? All Shoghi did against his was leave a 4 star review and tell him it blocked the main thread.
    FunneyShip likes this.
  4. ViperSniper
    Offline

    ViperSniper New Member

    Joined:
    Jun 5, 2014
    Posts:
    21
    Minecraft User:
    ViperSniper
    Allow it already. My server is the worst and it doesn't noticeably lag
    LDX likes this.
  5. iamadpond
    Offline

    iamadpond Banned

    Joined:
    Aug 24, 2013
    Posts:
    191
    Minecraft User:
    iamadpond
    Take it up with him, but if he says NO then he has a good reason. And here's what pocketmine forums are running on: Here
    LDX likes this.
  6. LDX
    Offline

    LDX Notable Member Plugin Developer

    Joined:
    Oct 2, 2013
    Posts:
    1,434
    Plugins:
    14
    Wait, what? The request doesn't go to PocketMine...
  7. iamadpond
    Offline

    iamadpond Banned

    Joined:
    Aug 24, 2013
    Posts:
    191
    Minecraft User:
    iamadpond
    Sorry was thinking about something else for that last post, ignore that one post.
    LDX likes this.
  8. iamadpond
    Offline

    iamadpond Banned

    Joined:
    Aug 24, 2013
    Posts:
    191
    Minecraft User:
    iamadpond
    Okay, so where are you saying the request will go? Here?
  9. ViperSniper
    Offline

    ViperSniper New Member

    Joined:
    Jun 5, 2014
    Posts:
    21
    Minecraft User:
    ViperSniper
    It's an equivelent to ajax request if i'm righr? I tweaked the code for custom broadcast messages
  10. ViperSniper
    Offline

    ViperSniper New Member

    Joined:
    Jun 5, 2014
    Posts:
    21
    Minecraft User:
    ViperSniper
    The request goes to minecraftpocket-servers.com/api
  11. ViperSniper
    Offline

    ViperSniper New Member

    Joined:
    Jun 5, 2014
    Posts:
    21
    Minecraft User:
    ViperSniper
    FunneyShip and LDX like this.
  12. Jag
    Offline

    Jag Active Member

    Joined:
    Mar 26, 2014
    Posts:
    53
    Minecraft User:
    Jag
    I am using it and I have not seen a problem. Based on the commentary above, I think it would ok with whatever warning is appropriate. However, I can barely use my keyboard with tripping myself, so don't assume I know a bit about what the plugin's code will do and whether or not it will cause the internet to crash and/or my house to catch fire or if LDX will become supreme Op of my server and he will then enslave all of the players so that they are forced to continuously make monuments to his greatness.
    LDX likes this.
  13. FunneyShip
    Offline

    FunneyShip Active Member

    Joined:
    Jun 7, 2014
    Posts:
    36
    Minecraft User:
    FunneyMan
    Its good no lags no craches . @LDX can i update your plugin to the new api
    LDX likes this.
  14. wies
    Offline

    wies Notable Member

    Joined:
    Aug 23, 2013
    Posts:
    392
    If minepocket-servers.com goes offline or is just slow, it will lag your server. You need to make a seperate pthread that checks the website. If shoghicp says no, then he has a valid reason for it and you should fix it instead of complaining and making a forum thread about it.
  15. LDX
    Offline

    LDX Notable Member Plugin Developer

    Joined:
    Oct 2, 2013
    Posts:
    1,434
    Plugins:
    14
    Every time I ask how to make a new pthread, I'm told to make a new pthread. :/
    FunneyShip likes this.
  16. LDX
    Offline

    LDX Notable Member Plugin Developer

    Joined:
    Oct 2, 2013
    Posts:
    1,434
    Plugins:
    14
    No thanks, I will. ;)
    CD123XD and FunneyShip like this.
  17. FunneyShip
    Offline

    FunneyShip Active Member

    Joined:
    Jun 7, 2014
    Posts:
    36
    Minecraft User:
    FunneyMan
    Okay
  18. wies
    Offline

    wies Notable Member

    Joined:
    Aug 23, 2013
    Posts:
    392
    It's well documentated on the internet, so don't bother someone if google knows. First read this: http://pthreads.org, it will give you a basic understanding of threads, workers and stacks. Then read the php manual:http://docs.php.net/manual/en/book.pthreads.php
    If you've read all that and still have a question, feel free to ask.
    LDX likes this.
  19. wies
    Offline

    wies Notable Member

    Joined:
    Aug 23, 2013
    Posts:
    392
    Or you could set the stream to timeout very quickly
  20. PEMapModder
    Offline

    PEMapModder Notable Member Plugin Developer

    Joined:
    Oct 9, 2013
    Posts:
    7,325
    Plugins:
    11
    Minecraft User:
    PEMapModder
    Hint: use AsyncTask for the new API; shoghicp said it's safer.
    LDX likes this.
Thread Status:
Not open for further replies.

Share This Page

Advertisement